-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add publisher stake caps to validator #1778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
guibescos
commented
Jul 18, 2024
pythnet/pythnet_sdk/src/messages.rs
Outdated
} | ||
} | ||
|
||
pub fn feed_id(&self) -> FeedId { | ||
match self { | ||
Self::PriceFeedMessage(msg) => msg.feed_id, | ||
Self::TwapMessage(msg) => msg.feed_id, | ||
Self::PublisherCapsMessage(_) => [0u8; 32], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new type of message breaks this
guibescos
changed the title
Feat/publisher caps
feat: add publisher stake caps to validator
Jul 18, 2024
guibescos
commented
Jul 22, 2024
Riateche
requested changes
Jul 24, 2024
keyvankhademi
approved these changes
Jul 30, 2024
Riateche
approved these changes
Jul 31, 2024
This reverts commit 48af94f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublisherStakeCapsMessage
is a new type of message, that contains how much stake each publisher should have to maximize their rewards in the context of CIP.This message is different from other messages in that there's only one message of this type in the Merkle tree, and also it is potentially really big (since it contains the list of all publishers and their cap).
https://forum.pyth.network/t/community-proposal-for-the-design-of-the-community-integrity-pool-cip/1571
I gets computed in pyth-network/pythnet#302 , and will be consumed by the reward distribution logic on Solana.